AirDog46/Kade-Engine
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #1278 from cuckydev/fix-susend

Browse Source 
Fix sustain notes more
This commit is contained in:
Kade M 2021-07-12 13:07:30 -07:00 committed by GitHub
commit 681dbee219
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
source/Note.hx
View File

@ -178,6 +178,8 @@ class Note extends FlxSprite
if (FlxG.save.data.downscroll && sustainNote) if (FlxG.save.data.downscroll && sustainNote)
flipY = true; flipY = true;
var stepHeight = (0.45 * Conductor.stepCrochet * FlxMath.roundDecimal(PlayStateChangeables.scrollSpeed == 1 ? PlayState.SONG.speed : PlayStateChangeables.scrollSpeed, 2));
if (isSustainNote && prevNote != null) if (isSustainNote && prevNote != null)
{ {
noteScore * 0.2; noteScore * 0.2;
@ -202,19 +204,13 @@ class Note extends FlxSprite
prevNote.animation.play(dataColor[prevNote.originColor] + 'hold'); prevNote.animation.play(dataColor[prevNote.originColor] + 'hold');
prevNote.updateHitbox(); prevNote.updateHitbox();
prevNote.noteYOff = 0; prevNote.scale.y *= (stepHeight + 1) / prevNote.height; // + 1 so that there's no odd gaps as the notes scroll
prevNote.scale.y *= (0.45 * Conductor.stepCrochet * FlxMath.roundDecimal(PlayStateChangeables.scrollSpeed == 1 ? PlayState.SONG.speed : PlayStateChangeables.scrollSpeed, 2)) / prevNote.height * 1.01; //The 1.01 is so that there aren't odd 1 pixel gaps as the notes scroll
prevNote.updateHitbox(); prevNote.updateHitbox();
prevNote.noteYOff = Math.round(-prevNote.offset.y);
// prevNote.setGraphicSize(); // prevNote.setGraphicSize();
switch (noteTypeCheck) noteYOff = Math.round(-offset.y);
{
case 'pixel':
noteYOff = -13;
default:
noteYOff = -23;
}
} }
} }
} }

4
source/PlayState.hx
View File

@ -2825,9 +2825,9 @@ class PlayState extends MusicBeatState
if (daNote.isSustainNote) if (daNote.isSustainNote)
{ {
daNote.x += daNote.width / 2 + 17; daNote.x += daNote.width / 2 + 20;
if (PlayState.curStage.startsWith('school')) if (PlayState.curStage.startsWith('school'))
daNote.x -= 8; daNote.x -= 11;
} }
// trace(daNote.y); // trace(daNote.y);